use env var GITHUB_TOKEN for api calls (if set) #65
Conversation
khassel
force-pushed
the
auth
branch
3 times, most recently
from
5410f17 to
e427891
Compare
|
Nice! I can't see an issue in the logs. We can merge as far as I'm concerned and I'd do a bit fine-tuning afterwards so that this line in the logs, for example, doesn't look so contradictory:
|
khassel
force-pushed
the
auth
branch
3 times, most recently
from
08f6899 to
b4f1b0c
Compare
Quick solution for me was to set Other point: With a full update per pipeline run I think it is sufficient to run the job only once a day. If this is o.k. for you I would update the sentence in the README.md here:
|
Yes, once a day should also be enough. |
|
can you estimate when it will end, in what timezone? |
atm the build is done in gitlab, there it runs ~20min. and I can set time and timezone as we want. |
|
The timing is not important to me. I think that since we have users all over the world, any time is okay. Sam, do you have a wish? |
|
I don't care when or where(tz), just don't want to pull the file if it hasn't been updated today |
|
Last updated you can see here: https://modules.magicmirror.builders/data/stats.json |
|
right, but have to drag down the entire file to get 1 line. dont want to do this 100 times a day for nothing. |
|
current setting:
so let us know which TZ and schedule time you want and you can add 30min |
|
30 5 * * * existing tz is fine |
3 participants
This is a draft PR which we discussed in the forum.
I'm not really sure that it worked with auth for all repos so please review the job log.
The result looks good so far, it is published here. The MMM-HusqvarnaAutomower repo has now an image and the correct license.
Job needed 18min. compared to 11:30 before (which is still good).